Error 3061 Too few Parameters. Expected 1

Anonymous
2011-09-10T21:05:32+00:00

I'm using a Union query as a Source for an Append query.  I will leave the code here.  tblGLTransactions and tblGLTranaactionNo. I don't know if that is causing a problem.  The tblGLTransactions has 2 fields, the fiest field GLTransactionNo is an autonumber field, so I didn't append to that field.  I need both tables because of the relationship for a form and subform for GLTransactions.  The entry I'm trying to append closes the year end.  Well, it should.

I should post the union query as well.   I have drained out John Vinson who has been helping my like crazy in the past two days.  This is the final step in completing this database and I cannoyt believe it crashes.

Here is the Union query ......I changed it.  No AccountTypeID and no AcctgDate.  IT's been modified for the extra fields. EDITED 09/12/11 12:51

SELECT qryYearEndReBalanceSheetTotals.AccountID, IIf([TotalTrans]<0,[TotalTrans]*-1,0) AS Debit, IIf([TotalTrans]>0,[TotalTrans],0) AS Credit, 0 AS GLTransactionNo, "Closing Entry" AS Source,qryYearEndReBalanceSheetTotals.TransDate FROM qryYearEndReBalanceSheetTotals

UNION ALL SELECT  ([Forms]![frmYrEndProcessing]![cboRetainedEarnings]) AS AccountID, IIf([SumOfProfit]<0,[SumOfProfit],0) AS Debit, IIf([SumOfProfit]>0,[SumOfProfit],0) AS Credit, 0 AS GLTransactionNo, "Closing Entry" AS Source, DLookUp("FiscalYearEndDate","tblMyCompanyInfo") AS TransDate FROM qryYearEndBalanceSheetProfit;

 Here is the code:  I created another query with GLTansactionNo and AcctgDate.   The same 2 fields as the table.  It still fails with the same Error 3061. Like the Title

   Thanks for any help.  this coded edited Sunday 09/12/11 12:54 pm

Private Sub cmdOkay_Click()

On Error GoTo ErrorHandler

    Dim dbs As DAO.Database

    Dim rst As DAO.Recordset

    Dim strSQL As String

    Dim lngID As Long

    Dim strMessage As String

    Dim IntMessageDialog As Integer

    Dim strTitle As String

    Dim intResult As Integer

     If Me!chkPrintFinancials = False Then

     MsgBox ("Print Financial Statements before Closing the Year End." & vbCrLf & _

     "Ensure Start and Fiscal Year End Dates are not Blank in My Company Information Form.")

     Else

                        If Nz(Me![cboRetainedEarnings].Value) = "" Then

                        MsgBox ("Choose an Account for Retained Earnings.")

                    End If

                End If

                    If Not Me.chkPrintFinancials = False And Me.cboRetainedEarnings > -1 Then

                   Me.cmdCancelAndExit.Enabled = False

                Else: Exit Sub

            End If

         DoCmd.Beep

                strMessage = "Are you sure you want to Close the Year End?"

                IntMessageDialog = vbQuestion + vbYesNo + vbDefaultButton1

                strTitle = "Confirm Year End Close"

                intResult = MsgBox(strMessage, IntMessageDialog, strTitle)

                        If intResult = vbNo Then

                                Exit Sub

                        End If

                        If intResult = vbYes Then

                            If IsNull(DLookup("FiscalYearEndDate", "tblMyCompanyInfo")) Then

                       MsgBox "Please fill in the fiscal year end date in the My Company info form", vbOKOnly

                        Exit Sub

                            Else

        strSQL = "INSERT INTO [tblGLTransactions] ( AcctgDate) SELECT AcctgDate FROM " _

        & "[qryYearEndGLTransactions] ;"

        CurrentDb.Execute strSQL, dbFailOnError

        lngID = DMax("GLTransactionNo", "tblGLTransactions")

        strSQL = "INSERT INTO [tblTransactions] (TransDate, AccountID, Debit, Credit," _

        & " Source, GLTransactionNo)" _

        & "SELECT TransDate, AccountID, Debit, Credit," _

        & "Source, " & lngID & " As GLTransactionNo FROM [qryuniYearEndFinalClosingEntry] ;"

        CurrentDb.Execute strSQL, dbFailOnError

        DBEngine(0)(0).Execute "qupdYearEndDateChanges", dbFailOnError

         MsgBox ("The Year End is Processed.")

    End If

End If

       DoCmd.Close acForm, Me.Name

        DoCmd.OpenForm "frmEnterGLTransactions"

        DoCmd.GoToRecord , , acLast

ErrorHandlerExit:

   Exit Sub

ErrorHandler:

   MsgBox "Error No: " & Err.Number & "; Description: " & Err.Description

  Debug.Print strSQL

   Resume ErrorHandlerExit

End Sub

Microsoft 365 and Office | Access | For home | Windows

Locked Question. This question was migrated from the Microsoft Support Community. You can vote on whether it's helpful, but you can't add comments or replies or follow the question.

0 comments No comments
Answer accepted by question author
Anonymous
2011-09-18T17:45:44+00:00

I will reply, Rob, if only to wish you good luck.  I wish I'd been able to resolve the issue for you, but I think we'd just be herding those kittens for evermore I'm afraid.

One final point of detail.  I'd recommend:

"#" & Format(Now(),"yyyy-mm-dd hh:nn:ss") & "#" & _

By using the ISO standard for date and time notation it caters for whatever Windows local date format is in use.  As you'd written it, it would fail on my system for instance as the UK short date format is dd/mm/yyyy, so 4th July would be changed to 7 April, which your neighbours to the south would not appreciate.

Was this answer helpful?

0 comments No comments
Answer accepted by question author
Anonymous
2011-09-12T23:19:56+00:00

Mea culpa. I left out spaces in two places.  BEFORE SELECT and BEFORE FROM

strSQL = "INSERT INTO [tblTransactions] (TransDate, AccountID, Debit, Credit," _

        & "Source, GLTransactionNo)" _

        & " SELECT TransDate, AccountID, Debit, Credit, Source," & lngID _

        & " FROM [qryuniYearEndFinalClosingEntry] ;"

        CurrentDb.Execute strSQL, dbFailOnError

If lngId is equal to 33, then Debug.Print should return

INSERT INTO [tblTransactions] (TransDate, AccountID, Debit, Credit,Source, GLTransactionNo) SELECT TransDate, AccountID, Debit, Credit, Source,33 FROM [qryuniYearEndFinalClosingEntry] ;

Was this answer helpful?

0 comments No comments

69 additional answers

Sort by: Oldest
  1. Anonymous
    2011-09-18T12:10:02+00:00

        Set qdf = dbs.QueryDefs(strQuery)

       

        For Each prm In qdf.parameters

        prm = Eval(prm.Name)

        Next prm

       

        Set rst = qdf.OpenRecordset

    You'd have to assign the name of a query to the strQuery variable first.  But this code is for opening a recordset based on a query which includes parameters, whereas you are executing an SQL statement.  I only posted it as an example of how to loop through the Parameters collection of a querydef object and evaluate each parameter, not as code which you could use.  It might be possible to evaluate the parameters of any queries used by the SQL statement, but it's not something I've ever tried.  You'd have to identify the queries which are used, regardless of how deeply they are nested, and evaluate their parameters independently, but you would not establish a recordset.

    Was this answer helpful?

    0 comments No comments
  2. Anonymous
    2011-09-18T12:29:40+00:00

    Im back at syntax I think

    As I said earlier, no matter how long I stare at your code I can't spot where the syntax error in the SQL statement might be.  I'm clearly missing something, but the methodology you've employed is pretty complex, and it's very difficult for me to get an overall picture of the process.  I don't think there's anything further I can contribute on this particular issue, but my gut feeling is that the problems are likely to stem from the nature of the underlying logical model, and that a rethinking of the underlying model might well make for far easier solutions.  I've often said to people 'get the logical model right and the interface will design itself, get it wrong and you end up jumping through hoops for ever more'.  Analysis of the logical model would require a far better understanding of accountancy than I posses, I'm afraid.  It might also mean jettisoning much of what you've done already, though I don't see that as an overriding objection.  After all, when in a hole the first thing to do is stop digging.

    Was this answer helpful?

    0 comments No comments
  3. Anonymous
    2011-09-18T17:05:25+00:00

    Thanks for replying ken.  Okay, should not have used the qrydefs.  I ahve to reaaly look the these queries.  Apart from wht you said about accounting, and your lack of understanding re: the queries, you were very helpful.

    I even added the DateTimeStamp field for append.

    Just FYI. I'm still getting error 3131 asa syntax error after I revised to include the DateTimeStamp fileld.  This is how it looks and it returns correct with the current date and time in  the immediate window.  Please Don't reply Ken.  You've done as much and more than I expect.

    Here is the revised code.  Just to post for information purposes,

    strSQL = "INSERT INTO [tblTransactions] " & _

        "(TransDate, AccountID, Debit, Credit, Source, GLTransactionNo, DateTimeStamp) " & _

        "SELECT " & _

        strTransDate & ", " & _

        "AccountID, " & _

        "IIf([TotalTrans]<0,[TotalTrans]*-1,0) AS Debit, " & _

         "IIf([TotalTrans]>0,[TotalTrans],0) AS Credit, " & _

         "'Closing Entry' AS Source, " & _

         lngID & " AS GLTransactionNo, " & _

         "#" & Now() & "# AS DateTimeStamp " & _

         "FROM qryYearEndReBalanceSheetTotals " & _

         "UNION ALL " & _

         "SELECT  " & _

         strTransDate & ", " & _

         [Forms]![frmYrEndProcessing]![cboRetainedEarnings] & ", " & _

         "IIf([SumOfProfit]>0,[SumOfProfit],0), " & _

         "IIf([SumOfProfit]<0,[SumOfProfit]*-1,0), " & _

         """Closing Entry"", " & _

         lngID & _

         "#" & Now() & "#" & _

        " FROM qryYearEndBalanceSheetProfit;"

        CurrentDb.Execute strSQL, dbFailOnError

    Thanks for all your help.  Don't reply Ken.

    I will do my best.

    Rob

    Was this answer helpful?

    0 comments No comments